Skip to content

feat(op-acceptance-tests): add EIP-7939 CLZ opcode acceptance test#20073

Merged
joshklop merged 1 commit intodevelopfrom
joshklop/osaka-7939
Apr 15, 2026
Merged

feat(op-acceptance-tests): add EIP-7939 CLZ opcode acceptance test#20073
joshklop merged 1 commit intodevelopfrom
joshklop/osaka-7939

Conversation

@joshklop
Copy link
Copy Markdown
Contributor

@joshklop joshklop commented Apr 14, 2026

Add TestEIP7939CLZ to verify the CLZ opcode (0x1e) is available after the Karst fork and unavailable before it. The test uses eth_call with init code that computes CLZ(1) = 255, asserting an invalid opcode error pre-fork and the correct result post-fork.

Stacked on #20073


For reference https://github.com/ethereum-optimism/design-docs/blob/main/protocol/fusaka-on-l2.md

@joshklop joshklop requested a review from a team as a code owner April 14, 2026 18:41
@joshklop joshklop force-pushed the joshklop/osaka-7939 branch from d66b7c0 to aa87c32 Compare April 14, 2026 20:21
@joshklop joshklop force-pushed the joshklop/osaka-7823 branch from 5debce5 to 4690eb8 Compare April 14, 2026 20:21
@joshklop joshklop force-pushed the joshklop/osaka-7939 branch from aa87c32 to dab9c51 Compare April 14, 2026 21:29
@joshklop joshklop force-pushed the joshklop/osaka-7823 branch from 4690eb8 to d9c1d39 Compare April 14, 2026 21:29
Base automatically changed from joshklop/osaka-7823 to develop April 15, 2026 02:56
Copy link
Copy Markdown
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not stacked in the way I expected, but I reviewed dab9c51 and that LGTM.

Add TestEIP7939CLZ to verify the CLZ opcode (0x1e) is available after
the Karst fork and unavailable before it. The test uses eth_call with
init code that computes CLZ(1) = 255, asserting an invalid opcode error
pre-fork and the correct result post-fork.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@joshklop joshklop force-pushed the joshklop/osaka-7939 branch from dab9c51 to 2ffcaf2 Compare April 15, 2026 20:06
@joshklop
Copy link
Copy Markdown
Contributor Author

This PR is not stacked in the way I expected, but I reviewed dab9c51 and that LGTM.

Sorry about that! Thanks for reviewing.

@joshklop joshklop enabled auto-merge April 15, 2026 20:07
@joshklop joshklop added this pull request to the merge queue Apr 15, 2026
Merged via the queue into develop with commit 6a7ab9e Apr 15, 2026
105 of 107 checks passed
@joshklop joshklop deleted the joshklop/osaka-7939 branch April 15, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants